Handle inject(&:+) in Performance/Sum #168
Merged
+35
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugeneius
force-pushed
the
sum_block_pass
branch
from
4ed4c3e
to
90a9aac
Compare
koic
reviewed
Sep 17, 2020
config/default.yml
Outdated
| @@ -271,6 +271,7 @@ Performance/Sum: | |||
| Reference: 'https://blog.bigbinary.com/2016/11/02/ruby-2-4-introduces-enumerable-sum.html' | |||
| Enabled: 'pending' | |||
| VersionAdded: '1.8' | |||
| VersionChanged: '1.9' | |||
There was a problem hiding this comment.
The next release is planned for 1.8.1 and I think this change can be included in the 1.8 series. Could you remove this one?
`inject(&:+)` is another slower way to write `sum`.
eugeneius
force-pushed
the
sum_block_pass
branch
from
90a9aac
to
19223fc
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #137.
inject(&:+)is another slower way to writesum.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.